Repository navigation
DOC: Correct quiver and streamline figure factory return types - #5823
Open
senanurcetin wants to merge 1 commit into
Open
senanurcetin wants to merge 1 commit into
senanurcetin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #5396.
The figure-factory documentation currently describes
create_quiver()andcreate_streamline()as returning dictionaries, even though both functions returnplotly.graph_objects.Figureinstances.Replace the misleading
dictreturn-type descriptions with clear NumPy-styleReturnssections.Add focused tests that verify both the return-type documentation and the actual
Figureobjects.Leave runtime plotting behavior and public API unchanged.
Verification
Executed on Windows / Python 3.11 against fork commit
1cd3b20:This is targeted verification, not a claim that the full upstream CI suite has passed. No changelog entry is needed for this documentation-only change.
AI assistance disclosure
OpenAI ChatGPT assisted with selecting the narrowly scoped documentation issue, drafting the change, and preparing its regression tests. The contributor remains responsible for the content and addressing maintainer feedback.
Additional existing regression tests (16 October 2026)
On the same PR commit
1cd3b20, independently ran Plotly's existing quiver and streamline tests:Combined with the new documentation assertions: 10 targeted test passes across two runs, with no failures. This is not a full upstream suite run. The first-contributor GitHub Actions workflows remain in
action_requireduntil an upstream maintainer permits them.Extended figure-factory module verification (16 October 2026)
After installing the previously missing optional
scikit-imagedependency into an isolated Python 3.11 environment, re-ran both complete relevant test files on exact PR commit1cd3b20:The 24 passes include the prior 10 targeted assertions; counts must not be added together. This does not establish a full Plotly test suite pass or maintainer-enabled GitHub Actions CI. The seven warnings were suppressed in summary, not triaged individually.